Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7441 redshift resource create/update/delete timeouts #8241

Merged
merged 2 commits into from
Apr 10, 2019
Merged

#7441 redshift resource create/update/delete timeouts #8241

merged 2 commits into from
Apr 10, 2019

Conversation

kirkbyers
Copy link
Contributor

Add timeouts to the aws_redshift_cluster resource to address issue linked (#7441).

I followed the suggestion in the issue of making it like https://www.terraform.io/docs/providers/aws/r/db_instance.html#timeouts and the related source code.

It is my first time contributing. I've read all the linked docs on contributing, but please let me know what needs to change. Thanks!

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7441

Changes proposed in this pull request:

  • Add Timeout for Redshift Cluster Creation, Update, and Delete
  • Updated tests to include changing a timeout
  • Updated documentation to reflect changes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRedshiftCluster'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRedshiftCluster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRedshiftCluster_importBasic
=== PAUSE TestAccAWSRedshiftCluster_importBasic
=== RUN   TestAccAWSRedshiftCluster_basic
=== PAUSE TestAccAWSRedshiftCluster_basic
=== RUN   TestAccAWSRedshiftCluster_withFinalSnapshot
=== PAUSE TestAccAWSRedshiftCluster_withFinalSnapshot
=== RUN   TestAccAWSRedshiftCluster_kmsKey
=== PAUSE TestAccAWSRedshiftCluster_kmsKey
=== RUN   TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
=== PAUSE TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
=== RUN   TestAccAWSRedshiftCluster_loggingEnabled
=== PAUSE TestAccAWSRedshiftCluster_loggingEnabled
=== RUN   TestAccAWSRedshiftCluster_snapshotCopy
=== PAUSE TestAccAWSRedshiftCluster_snapshotCopy
=== RUN   TestAccAWSRedshiftCluster_iamRoles
=== PAUSE TestAccAWSRedshiftCluster_iamRoles
=== RUN   TestAccAWSRedshiftCluster_publiclyAccessible
=== PAUSE TestAccAWSRedshiftCluster_publiclyAccessible
=== RUN   TestAccAWSRedshiftCluster_updateNodeCount
=== PAUSE TestAccAWSRedshiftCluster_updateNodeCount
=== RUN   TestAccAWSRedshiftCluster_updateNodeType
=== PAUSE TestAccAWSRedshiftCluster_updateNodeType
=== RUN   TestAccAWSRedshiftCluster_tags
=== PAUSE TestAccAWSRedshiftCluster_tags
=== RUN   TestAccAWSRedshiftCluster_forceNewUsername
=== PAUSE TestAccAWSRedshiftCluster_forceNewUsername
=== RUN   TestAccAWSRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccAWSRedshiftCluster_changeAvailabilityZone
=== RUN   TestAccAWSRedshiftCluster_changeEncryption1
=== PAUSE TestAccAWSRedshiftCluster_changeEncryption1
=== RUN   TestAccAWSRedshiftCluster_changeEncryption2
=== PAUSE TestAccAWSRedshiftCluster_changeEncryption2
=== CONT  TestAccAWSRedshiftCluster_importBasic
=== CONT  TestAccAWSRedshiftCluster_publiclyAccessible
=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
=== CONT  TestAccAWSRedshiftCluster_changeEncryption2
=== CONT  TestAccAWSRedshiftCluster_changeEncryption1
=== CONT  TestAccAWSRedshiftCluster_changeAvailabilityZone
=== CONT  TestAccAWSRedshiftCluster_forceNewUsername
=== CONT  TestAccAWSRedshiftCluster_tags
=== CONT  TestAccAWSRedshiftCluster_updateNodeType
=== CONT  TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled
=== CONT  TestAccAWSRedshiftCluster_withFinalSnapshot
=== CONT  TestAccAWSRedshiftCluster_iamRoles
=== CONT  TestAccAWSRedshiftCluster_snapshotCopy
=== CONT  TestAccAWSRedshiftCluster_kmsKey
=== CONT  TestAccAWSRedshiftCluster_basic
=== CONT  TestAccAWSRedshiftCluster_loggingEnabled
--- PASS: TestAccAWSRedshiftCluster_tags (609.50s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (630.01s)
--- PASS: TestAccAWSRedshiftCluster_importBasic (639.67s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (649.04s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (650.16s)
--- PASS: TestAccAWSRedshiftCluster_basic (650.67s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (660.05s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (711.71s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (733.98s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (889.45s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1075.75s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1089.13s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (3828.96s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (4028.25s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (4153.38s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (4364.24s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       4364.303s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Apr 8, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 10, 2019
@bflad bflad added this to the v2.6.0 milestone Apr 10, 2019
bflad
bflad approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @kirkbyers, thanks! 🚀

--- PASS: TestAccAWSRedshiftCluster_importBasic (595.43s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (596.31s)
--- PASS: TestAccAWSRedshiftCluster_basic (601.30s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (606.46s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (614.99s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (620.86s)
--- PASS: TestAccAWSRedshiftCluster_tags (664.97s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (737.86s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (778.27s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1046.16s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1098.56s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1198.69s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (4002.02s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (4072.91s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (4133.35s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (4404.02s)

@bflad bflad merged commit 6ae498c into hashicorp:master Apr 10, 2019
bflad added a commit that referenced this pull request Apr 10, 2019
@bflad
Update CHANGELOG for #8241
1d6c997
@kirkbyers kirkbyers deleted the kbye/#7441-redshift-timeouts branch April 10, 2019 20:52
@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

provider/aws Redshift create/update configurable timeout
2 participants
@kirkbyers @bflad